Skip to content

Commit 861b0f8

Browse files
authored
fix: loader on cluster search bar spin forever (#542)
**Describe the pull request** This PR addresses a bug where the loading spinner in the cluster search bar would continue to spin indefinitely when a user performs a search. **Checklist** - [x] I have made the modifications or added tests related to my PR - [x] I have run the tests and linters locally and they pass - [x] I have added/updated the documentation for my RP --------- Signed-off-by: Atomys <[email protected]>
1 parent 06ffdb4 commit 861b0f8

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

web/ui/src/components/Search/Search.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export const Search: SearchComponent = ({
120120
<span
121121
className={
122122
loader
123-
? 'absolute right-2 bg-white dark:bg-slate-950 z-10'
123+
? 'absolute right-2 bg-slate-200 dark:bg-slate-950 z-10'
124124
: 'hidden'
125125
}
126126
>

web/ui/src/containers/clusters/ClusterSidebar.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,7 @@ export const ClusterSidebar = ({
8686
user?.currentLocation?.identifier as string,
8787
);
8888

89-
if (url) {
90-
router.replace(url);
91-
return new Promise(() => {});
92-
}
89+
return url ? router.replace(url) : Promise.reject();
9390
}}
9491
/>
9592
<div>

0 commit comments

Comments
 (0)