Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantify metadatavalues not to exposure the orcid authentication date #400

Open
floriangantner opened this issue Nov 9, 2023 · 0 comments

Comments

@floriangantner
Copy link

Is your feature request related to a problem? Please describe.
In the migration procedure from DSpace 5.10 to Dspace7 the metadatafield dspace.orcid.authenticated field is filled with boolean values like

New successful linked profiles will get the date of the authentication

itemService.setMetadataSingleValue(context, profile, "dspace", "orcid", "authenticated", null, currentDate);

The only usage we found is in the metadata-link-view.component.ts to show the orcid when the person is authenticated
https://github.com/4Science/dspace-angular/blob/f5553efe4047fbdef0c667f0b28f1ee8f45930aa/src/app/shared/metadata-link-view/metadata-link-view.component.ts#L116C1-L116C1

Describe the solution you'd like

In our point of view this date is some sensitive data from some interaction between the researcher and some external system. This date is useful for administrators - we must admin - but has no real value for anonymous users.

We wonder if there might be some mechanisms which quantifies values, e.g. return some boolean for the existence of the metadata instead. This might be included in the MetadataSecurityService and be configurable on certain metadatafields

Describe alternatives or workarounds you've considered
in case all your orcids are authenticated and you do not collect unauthenticated orcids this can be fixex on the frontend side by changing the above linked metadata-link-view.component

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant