Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove optional affiliation startdate from orcid validation #364

Open
wants to merge 2 commits into
base: dspace-cris-2023_02_x
Choose a base branch
from

Conversation

floriangantner
Copy link

References

Add references/links to any related issues or PRs. These may include:

Description

see issue for more details

Instructions for Reviewers

List of changes in this PR:

  • remove validation of affiliation startdate. This is not necessary in the orcid scheme
  • adopt tests

Include guidance for how to test or review your PR.

  • create some affiliation without startdate and push to orcid
  • or check the orcid api scheme

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@corrad82-4s corrad82-4s self-requested a review August 8, 2023 10:06
@floriangantner floriangantner changed the base branch from dspace-cris-7 to main-cris February 14, 2024 15:49
…lidation

[maven-release-plugin] copy for tag dspace-cris-2023.02.02
@floriangantner
Copy link
Author

aligned to 2023.02.02 Release

@floriangantner floriangantner changed the base branch from main-cris to dspace-cris-2023_02_x April 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orcid affiliation validation checks optional start-date field as required
1 participant