-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube session invalidation - simply exits instead of reloading #12
Comments
@Farzat07 thanks for reporting, I'll try to reproduce this issue. How long do I need to wait until the cache invalidation happens? |
I never really measured the time, but I guess around 6 hours should be enough. |
Ugh, it'll take some time to reproduce. BTW, after reading the issue again
The plugin has an option to check for more content after the EOF is reached. But it is disabled by default.
Maybe try enabling it and see if that helps. |
Yeah but I believe that is supposed to be for different use cases e.g. a live stream. |
Hmm... it does not happen to me, at least with YouTube videos. Can use send a link that triggers this behavior when played with mpv? |
Ok I was wrong actually - it does not actually get into a loop, but it does get stuck at the ending which makes it seem like so. At the EOF the video reloads and as there is nothing left to play, the video just stays as it is. If you go back 5 seconds, it plays them again with distorteed voice and then exits. I'm finding this behaviour consistent across videos, even local ones. You can reproduce with this one https://videos.lukesmith.xyz/w/jNDH1cnxNfwwJH2pZvAqdM. The only exception was youtube though - it just exited normally after discovering that this is actually the end of the file. In the end this setting seems to effectively mimic the --keep-open option as a side effect (at least in the majority of cases). It might work as a temporary solution but I don't think it is ideal. |
I'm trying to check the link. youtube-dl does not recognize the file format, are you using a different backend?
|
Yeah I'm using yt-dlp because they applied the fix to that (peertube links). You can use this static link though, same effect. https://videos.lukesmith.xyz/static/webseed/9847f270-f9ab-42ff-8d33-a59da419b245-480.mp4 |
Hmm... For me, the video doesn't get stuck or get into a loop. On EOF it reloads and then exits.
I'm using the default |
Ok I tried the original youtube-dl backend, same problem. But then I tried changing my configuration to see if one of my settings was causing this: turns out the culprit is I still need that setting though - without it replaygain settings can't be used on playlists (check mpv-player/mpv#8267). |
I assume it has something to do with the latency, maybe I wasn't lucky enough. Anyway, I'll try to reproduce the original issue with the timed-out YouTube session. |
When a youtube video is left paused in mpv for a long time, the session becomes invalidated (naturally). However, when resumed and the cached amount is consumed, mpv simply exits as it thinks the EOF has been reached. The expected behaviour would be to reload the video from its original url.
The following error messages are the only ones which appear after the youtube session has been invalidated:
where X takes the value of 0, 1, 3, and 7.
The text was updated successfully, but these errors were encountered: