Elias/issue#13/SeperateSections on engineering &c. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komali2
requested changes
Apr 28, 2023
| border-radius: 2px; | ||
| margin: var(--margin-big); | ||
| border-radius: 10px; | ||
| margin-top: 50px; |
There was a problem hiding this comment.
changing the margin away from a variable makes me nervous, i'd prefer the guaranteed consistency of margins by keeping that to be a variable
There was a problem hiding this comment.
other than that, I kinda like this idea you have with the border that has these sort of half radius things. That's interesting. i think if they weren't harsh black, it could work. Maybe fiddle with some of the other color variables from :root to see if one of those work? we could also try reducing opacity a bit to lighten them.
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #13
Separated sections on the engineering page, mostly by updating css for
Also added class="index" to a couple sections to improve visual separation.