Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check performance of wrapper functions #167

Open
nuest opened this issue Apr 22, 2020 · 0 comments
Open

Check performance of wrapper functions #167

nuest opened this issue Apr 22, 2020 · 0 comments

Comments

@nuest
Copy link
Contributor

nuest commented Apr 22, 2020

Reported via email:

niwaClimate <- SOS(url = "https://climate-sos.niwa.co.nz",
binding = "KVP",
useDCPs = FALSE,
version = "2.0.0")

Each function call can take 5-10 seconds to retrieve some basic sites and phenomena information, which seems a bit long.

For example,

sites <- sites(sos = niwaClimate, empty = TRUE)
siteList <- siteList(sos = niwaClimate)
phenomena <- phenomena(sos = niwaClimate,
includeTemporalBBox = TRUE,
includeSiteId = TRUE)

Some profile analysis may point towards potential code optimisation places.

For example, for the phenomena function, a profile indicates that the
function parseTimePosition takes up a good chunk of the processing time.

@EHJ-52n @BenGraeler Would be great if you can support here.

@nuest nuest added this to To do in Release 0.5 via automation Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 0.5
  
To do
Development

No branches or pull requests

1 participant