Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] - enumerate api/spells/{index} -> damage field #289

Open
ecshreve opened this issue Mar 27, 2022 · 0 comments
Open

[documentation] - enumerate api/spells/{index} -> damage field #289

ecshreve opened this issue Mar 27, 2022 · 0 comments

Comments

@ecshreve
Copy link
Contributor

Currently the damage field in the Spell schema that describes response from this endpoint looks like this:

damage: {
  damage_at_slot_level: {
    <any-key>: any
  }
  damage_type: {
    index: string
    name: string
    url: string
  }
}

but this isn't entirely accurate. this field may also include a field named damage_at_character_level. would be nice to clean this schema up so it's fully accurate. here's some links that might be helpful

https://swagger.io/docs/specification/data-models/data-types/
https://swagger.io/docs/specification/describing-responses/
https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants