Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Threshold for a single file to fail the build #66

Open
joshuabremer opened this issue Feb 7, 2022 · 2 comments
Open

RFC: Threshold for a single file to fail the build #66

joshuabremer opened this issue Feb 7, 2022 · 2 comments

Comments

@joshuabremer
Copy link

Hi all, I was certain there was a bug in the action, but then realized my issue...the failing threshold is for the total report, not each individual file.

I'd like a propose a new option that defines a threshold that EVERY file needs to be above. Thoughts? Concerns?

I'm already relatively deep in the codebase and know how I would implement it, so I'm more wondering if you think this would be a good addition or not.

@joshuabremerdexcom
Copy link

Here's a mostly good to go PR: #67

@Rasmus-Fink
Copy link

Rasmus-Fink commented Jan 17, 2024

Having the exact same problem here.
Any plans on fixing this ?
+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants