Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common prefix #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

leftshift
Copy link

The old algorithm for determining the common prefix and trimming the folder name didn't work correctly when the glob result contained folder names that had the same prefix but then diverged. It then outputted just an empty folder name.

E.g.:
a/b-c/coverage.xml and a/b-d/coverage.xml would yield empty folder names for the separate paths.

I've instead opted to operate on path fragment level and comparing the folder names. This might subtly change the folder names the action outputs, e.g. no leading slash.

This also fixes #68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same file coverage is displayed multiple times
1 participant