Update to xunit.runner.visualstudio 3.0.0 breaks net48 unit tests

[6bee]

Description

Update of xunit.runner.visualstudio from 2.8.2 to 3.0.0 breaks a bunch of unit tests when executed under .NET 4.8 with a failure to resolve System.Linq.Async.Queryable methods via Aqua.TypeSystem.TypeResolver:

Aqua.TypeSystem.TypeResolverException : Failed to resolve method 'System.Threading.Tasks.ValueTask`1[System.Double] System.Linq.AsyncQueryable.AverageAsync(System.Linq.IAsyncQueryable`1[System.Int32], System.Threading.CancellationToken)'

  Stack Trace: 
RemoteToSystemLinqTranslator.ResolveMethod(MethodInfo method) line 111
RemoteToSystemLinqTranslator.VisitMethodCall(MethodCallExpression node) line 333
RemoteToSystemLinqTranslator.Visit(Expression node) line 88
RemoteToSystemLinqTranslator.ToExpression(Expression expression) line 79
ExpressionTranslationExtensions.ToLinqExpression(Expression expression, IExpressionFromRemoteLinqContext context) line 58
ExpressionExecutor`2.Transform(Expression expression) line 76
<ExecuteAsync>d__1.MoveNext() line 45
--- End of stack trace from previous location where exception was thrown ---
ExceptionDispatchInfo.Throw()
TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
<11 more frames...>

Short-term Resolution

• xunit.runner.visualstudio is reverted back to 2.8.2
• comment is added to Remote.Linq\test\Directory.Build.props for a heads-up

ACC

• root cause is identified
• mitigation is implemented

Root Cause

This issue arises for ValueTask<> when being resolved via Aqua.TypeSystem.TypeResolver and then does not match method signature since ValueTask<> being defined in more that one assembly:

• System.Threading.Tasks.Extensions
• xunit.runner.visualstudio.testadapter

System.Threading.Tasks.ValueTask`1, System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
System.Threading.Tasks.ValueTask`1, xunit.runner.visualstudio.testadapter, Version=3.0.0.0, Culture=neutral, PublicKeyToken=null

[6bee]

xunit/visualstudio.xunit#431