From 4d06b25444bb3ff9c2a6c7f8c30f0760bc49153c Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Sat, 7 Sep 2024 14:00:07 -0400 Subject: [PATCH] fix: typo in `setColumnVisibiliy` - keep previous method around to avoid breaking users but deprecate it --- examples/example-column-hidden.html | 4 ++-- src/controls/slick.columnmenu.ts | 5 +++++ src/controls/slick.columnpicker.ts | 5 +++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/examples/example-column-hidden.html b/examples/example-column-hidden.html index 817e44bc0..37cdcbd28 100644 --- a/examples/example-column-hidden.html +++ b/examples/example-column-hidden.html @@ -73,7 +73,7 @@

Demonstrates:

View Source:

@@ -265,7 +265,7 @@

View Source:

var hideCol = document.querySelector('#chkHideColumn').checked || false; // use the columnpicker since it keeps a full list of columns, hidden and visible - columnpicker.setColumnVisibiliy('duration', !hideCol); + columnpicker.setColumnVisibility('duration', !hideCol); }); // initialize the model after all the events have been hooked up diff --git a/src/controls/slick.columnmenu.ts b/src/controls/slick.columnmenu.ts index bc444c190..7db733633 100644 --- a/src/controls/slick.columnmenu.ts +++ b/src/controls/slick.columnmenu.ts @@ -294,7 +294,12 @@ export class SlickColumnMenu { } } + /** @deprecated because of a typo @use `setColumnVisibility()` instead */ setColumnVisibiliy(idxOrId: number | string, show: boolean) { + this.setColumnVisibility(idxOrId, show); + } + + setColumnVisibility(idxOrId: number | string, show: boolean) { const idx = typeof idxOrId === 'number' ? idxOrId : this.getColumnIndexbyId(idxOrId); let visibleColumns: Column[] = this.getVisibleColumns(); const col = this.columns[idx]; diff --git a/src/controls/slick.columnpicker.ts b/src/controls/slick.columnpicker.ts index 3d9927327..aaeb115b4 100644 --- a/src/controls/slick.columnpicker.ts +++ b/src/controls/slick.columnpicker.ts @@ -301,7 +301,12 @@ export class SlickColumnPicker { } } + /** @deprecated because of a typo @use `setColumnVisibility()` instead */ setColumnVisibiliy(idxOrId: number | string, show: boolean) { + this.setColumnVisibility(idxOrId, show); + } + + setColumnVisibility(idxOrId: number | string, show: boolean) { const idx = typeof idxOrId === 'number' ? idxOrId : this.getColumnIndexbyId(idxOrId); let visibleColumns = this.getVisibleColumns(); const col = this.columns[idx];