The C command does not respect tabs correctly

[pjungkamp]

Summary

• j/J/k/K handle vertical navigation in files with tabs correctly.
• C does not take the width of a tab character into account when navigating vertically.

Example

int main(int argc, char const *argv[]) {
    printf("Hello World");
    return 0;
}

Assume this snippet to be indented with a tabwidth of 4.

1. Copy this example to a new VSCode editor.
2. Run Change Tab Display Size and set width to 4.
3. Run Convert Indentation to Tabs.
4. Type %smain<ret> in normal mode to select the main functions name.
5. Type C.

Expected Behaviour

main on line 1 and prin on line 2 are selected.

Observed Behaviour

main on line 1 and ntf( on line 2 are selected.

[71]

Thanks for the report! Indeed that's not great. I'm not sure I have time to work on it right now, but here are some pointers:

• The function that implements C is tryCopySelection().
• Vertical movements (implemented by select.vertically()) use Lines.column(), which handles tab characters.

I suspect fixing C is mostly a matter of using Lines.column() rather than pure VS Code APIs at the right places in tryCopySelection() (and adding a test to avoid future regressions).