Fix: wait for windows app to exit as well #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 'Could not create process with command' error
* Fix the detection of targets that use the GUI subsystem * Allocate path on the stack
I've sometimes fiddled with scripts and shims for shortcuts and I really would've appreciated having this error tell me it's the shim telling me that I'm dumb and set up my path wrong, I hope this helps other fiddlers like me in the future
Co-Authored-By: felipecrs <[email protected]>
* build: Add zig build system support Signed-off-by: Chawye Hsu <[email protected]> * note about recent zig requirement Signed-off-by: Chawye Hsu <[email protected]> * add build.ps1 Signed-off-by: Chawye Hsu <[email protected]> * build: move zig build script to build folder Signed-off-by: Chawye Hsu <[email protected]> * build(zig): set subsystem to console Signed-off-by: Chawye Hsu <[email protected]> * conditional corecrt_wstdio.h inclusion Signed-off-by: Chawye Hsu <[email protected]> * build: fix build.ps1 and support building for x86 Signed-off-by: Chawye Hsu <[email protected]> * build: update build.ps1 Signed-off-by: Chawye Hsu <[email protected]> * chore: i386 -> ia32 Signed-off-by: Chawye Hsu <[email protected]> --------- Signed-off-by: Chawye Hsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16