Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeshifts can occur due to re-taking datetime.now in sub procedures #47

Open
rrozema opened this issue Feb 5, 2021 · 0 comments
Open

Comments

@rrozema
Copy link

rrozema commented Feb 5, 2021

datetime.now() is used in multiple places to determine state changes and also to calculate time periods. Because some subroutines determine a new value for "now", instead of using the same value as it's caller, small errors will occur in the times used. Accumulated these small errors in time result in small errors in the calculated constants.

A fix is to determine "now" only once per "run".

I will post a pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant