Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the spack-version explicitly when @git.<gitref> is used #96

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

harshula
Copy link
Contributor

@harshula harshula commented Jan 31, 2025

  • Spack upstream is planning to insert a spack-version when one is not explicitly provided.
  • The error we saw when using spack config change can be avoided when a spack-version is explicitly provided.
  • This change depends on the latest spack-packages.

🚀 The latest prerelease access-om2/pr96-1 at d18ea21 is here: #96 (comment) 🚀

@harshula harshula requested a review from CodeGat January 31, 2025 04:14
@harshula harshula self-assigned this Jan 31, 2025
@harshula
Copy link
Contributor Author

Testing

ACCESS-NRI/spack-packages#185

@harshula
Copy link
Contributor Author

harshula commented Feb 3, 2025

Hi @CodeGat , Will you be able to expand the CI regexp today?

@CodeGat
Copy link
Member

CodeGat commented Feb 3, 2025

Updating the schema is fine, the issue is that it would require changes to the infrastructure as well. We have a big infrastructure update coming soon, and I could add it to that.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

Copy link
Contributor

github-actions bot commented Feb 3, 2025

🚀 Deploying access-om2 2024.03.1 as prerelease pr96-1 with commit d18ea21

Details and usage instructions

This access-om2 model will be deployed as:

  • 2024.03.1 as a Release (when merged).
  • pr96-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om2/pr96-1

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om2-pr96-1 environment.

🛠️ Using: spack 0.22, spack-packages 2025.01.1, spack-config 2025.01.1

Details

It will be deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.01.1
  • access-nri/spack-config version 2025.01.1

If this is not what was expected, commit changes to config/versions.json.

* Spack upstream is planning to insert a spack-version when one is
  not explicitly provided.
* The error we saw when using `spack config change` can be avoided
  when a spack-version is explicitly provided.
* The latest spack-packages repository contains changes that this
  change requires.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

2 participants