Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action to Build Catalog #133

Open
anton-seaice opened this issue Oct 19, 2023 · 5 comments
Open

Github Action to Build Catalog #133

anton-seaice opened this issue Oct 19, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@anton-seaice
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

To build the catalog currently requires manual intervention.

Describe the feature you'd like

When a pull request is created - build a copy of the catalog on Gadi, and make available to the developer/reviewer to fix any issues.

When a new version is tagged - build a copy of the catalog on Gadi and move it to the public copy (initially with an extra step for a human to confirm first?)

This should be possible with github actions.

Describe alternatives you've considered

We could write an instruction for a reviewer on how to build the catalog, or use the access-dev jenkins server or similar.

Additional context

@anton-seaice anton-seaice added the enhancement New feature or request label Oct 19, 2023
@dougiesquire
Copy link
Collaborator

I agree it would be nice to have a full CD workflow. This has been on my todo list for a long time, but I've been waiting for the Github runners Aidan's team are setting up on Nirin (we definitely don't want to use access-dev as that will not be available very soon). We could instead just ssh from a Github runner.

One difficulty is that the full build takes ~1.5 hours and so we probably don't want to be doing this with every pull request. But we could set things up so that users could trigger a "non-release" build from Github if they wanted to.

@anton-seaice
Copy link
Collaborator Author

anton-seaice commented Oct 19, 2023 via email

@dougiesquire
Copy link
Collaborator

Aidan says they're still testing the Nirin Github runner, but it should be ready in the next week or so

@dougiesquire
Copy link
Collaborator

dougiesquire commented Jan 8, 2024

Note @rbeucher made a start on this but I'm not sure how much further he plans to take it? What he's added so far is a github workflow to manually trigger the build job on Gadi. As discussed in this thread, it would be good to have the build happen automatically on releases and PRs, but a little extra logic is required for handling non-release builds (could be as simple as building to tmp). @rbeucher, have you finished what you've been adding or are you planning to do more?

@rbeucher rbeucher self-assigned this Sep 30, 2024
@rbeucher
Copy link
Member

Will revisit this in the next couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

3 participants