Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mocks in test_CatalogManager_load_invalid_model #257

Open
charles-turner-1 opened this issue Nov 18, 2024 · 0 comments
Open

Replace mocks in test_CatalogManager_load_invalid_model #257

charles-turner-1 opened this issue Nov 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@charles-turner-1
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The tests adde for more thorough catalog manager error handling in #255 relied on mocking exceptions raised from intake-dataframe-catalog.

I'm not really a fan of doing this as we're making assumptions about the error handling in that package, rather than the data, and so I would like to replace these mocks with a proper test of system response to data that should lead to the mocked exceptions being raised from intake-dataframe-catalog.

This will take a bit of time to do, so I'm leaving it as an issue for now & will replace the mocks after release 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant