-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1.0 Release / ACCESS-NRI COSIMA Training on 21/02/2025 #324
Comments
I'll take on the data addition #319 once Gadi comes back up. |
Also, I think #195 could be a handy addition if this is a pre-workshop release. |
Bit of Friday afternoon cleanup:
I still haven't worked out conda feedstocks to my satisfaction & I'd like to spend some time working on ESMValCore <=> intake integration, so I think maybe we leave the telemetry for this release? |
Great 👍 |
So I can't do that because the current access-nri-intake package has a strong dependency on intake==0.7.0 while intake-esm 2025.2.3 has dependency intake>=2.0.0.... |
Must be somewhere else, no? |
Weird.. we updated the dependencies in pyproject.toml in #232 and #233, so long before the 1.0.0 release. There must be some other dependencies file buried somewhere - presumably for conda - see below. $ cd ~/scratch/
$ python -m venv venv
$ source venv/bin/activate.fish
$ pip install access-nri-intake
Collecting access-nri-intake
Downloading access_nri_intake-1.0.0-py3-none-any.whl.metadata (3.4 kB)
Collecting cftime (from access-nri-intake)
Using cached cftime-1.6.4.post1-cp312-cp312-macosx_11_0_arm64.whl.metadata (8.7 kB)
Collecting ecgtools>=2023.7.13 (from access-nri-intake)
Using cached ecgtools-2024.7.31-py3-none-any.whl.metadata (3.9 kB)
Collecting intake>=0.7.0 (from access-nri-intake)
Using cached intake-2.0.8-py3-none-any.whl.metadata (2.4 kB)
...
$ pip list | rg 'intake'
access_nri_intake 1.0.0
intake 2.0.8
intake_dataframe_catalog 0.3
intake-esm 2025.2.3 I'll dive into it and see what I can work out - presumably this is something dumb and hopefully fairly trivial 🤞 . |
Aha - only updated the I guess we'll need to release 1.1.0 before we can rebuild the conda environment then? |
Should we replace the conda package for 1.0.0? |
Yeah, I think so. I've had issues with trying to overwrite releases on PyPI before - not sure if this also an issue with conda/you've ever ran into this? I suspect if we branch from wherever the head was at 1.0.0, apply #323 to that and then release that as a 1.0.1, that might be a tad simpler? |
I've set up a v1.0.1 branch here, just gonna run the E2E tests and all being well I'll push the v1.0.1 tag. |
I have updated the package on conda but now I have the same issue with intake-dataframe-catalog. Let me know what you think is best, we can edit the packages dependencies or wait for a new release |
I'm just dealing with some (potentially) related issues - end to end tests are now failing due to Either way, the issue is in intake-dataframe-catalog, so I'll make my fixes there & then make a PR with all the fixes & the updated meta.yaml once I'm confident on there. |
We would like to release 1.1.0 in time for the ACCESS-NRI COSIMA Training on 21/02/2025.
The crucial feature to include for this release is #317, and probably searchable coordinate variables, but I've added some extra features that I think it would be good to include in the release - if possible & we have time to do so.
@marc-white @chrisb13 @anton-seaice @dougiesquire @rbeucher
Features to include:
intake-esm
build with discoverable coordinates - added in Cannot open coordinate variables from Intake-ESM datastores intake/intake-esm#660, awaiting release.Optional?
Deferred
Post-Release:
Is there anything I've missed that should be added/people feel should be removed?
The text was updated successfully, but these errors were encountered: