Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 1deg_jra55do_iaf branch #15

Closed
aekiss opened this issue Oct 18, 2023 · 9 comments
Closed

make 1deg_jra55do_iaf branch #15

aekiss opened this issue Oct 18, 2023 · 9 comments
Assignees
Labels
1deg_jra55do_iaf 1deg_jra55do_iaf configuration

Comments

@aekiss
Copy link
Contributor

aekiss commented Oct 18, 2023

I'll pull together a 1deg_jra55do_iaf branch, based on 1deg_jra55do_ryf but with the relevant changes from @ezhilsabareesh8's https://github.com/COSIMA/MOM6-CICE6/tree/1deg_jra55_iaf_iss33

@aekiss aekiss self-assigned this Oct 18, 2023
@aekiss aekiss added the 1deg_jra55do_iaf 1deg_jra55do_iaf configuration label Oct 18, 2023
@aekiss
Copy link
Contributor Author

aekiss commented Oct 18, 2023

OK, initial merge done.

In merging these I noticed some variables in datm.streams.xml have offsets in 1deg_jra55_iaf_iss33 that differ from those in 1deg_jra55do_ryf. I suspect this needs to be fixed - see COSIMA/access-om3#33 (comment)

@ezhilsabareesh8
Copy link
Contributor

Thanks @aekiss. The offset is required for IAF since some of the variables in JRA55do-IAF start at 0:00 hrs (temperature, velocities,..) and other variables at 1:30 hrs (rainfall flux, snow flux,...), so I set a positive offset of 5400 seconds (1.5hrs) for the variables that starts at 0:00hrs. I tested this configuration and working fine.

@aekiss
Copy link
Contributor Author

aekiss commented Oct 23, 2023

Ah, I didn't realise the offsets are different in the RYF and IAF data.

for f in /g/data/ik11/inputs/JRA-55/RYF/v1-4/*.nc; do echo $f; ncdump -v time $f | grep "^ time"; done
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.friver.1990_1991.nc
 time = 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.huss.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.licalvf.1990_1991.nc
 time = 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.prra.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.prsn.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.psl.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.rhuss.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.rlds.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.rsds.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.tas.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.uas.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
/g/data/ik11/inputs/JRA-55/RYF/v1-4/RYF.vas.1990_1991.nc
 time = 0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25,
for f in /g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/*/*/*/*/*/*1958*.nc; do echo $f; ncdump -v time $f | grep "^ time"; done
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hr/prra/gr/v20190429/prra_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010130-195812312230.nc
 time = 21184.0625, 21184.1875, 21184.3125, 21184.4375, 21184.5625,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hr/prsn/gr/v20190429/prsn_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010130-195812312230.nc
 time = 21184.0625, 21184.1875, 21184.3125, 21184.4375, 21184.5625,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hrPt/huss/gr/v20190429/huss_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010000-195812312100.nc
 time = 21184, 21184.125, 21184.25, 21184.375, 21184.5, 21184.625, 21184.75,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hrPt/psl/gr/v20190429/psl_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010000-195812312100.nc
 time = 21184, 21184.125, 21184.25, 21184.375, 21184.5, 21184.625, 21184.75,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hrPt/tas/gr/v20190429/tas_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010000-195812312100.nc
 time = 21184, 21184.125, 21184.25, 21184.375, 21184.5, 21184.625, 21184.75,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hrPt/ts/gr/v20190429/ts_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010000-195812312100.nc
 time = 21184, 21184.125, 21184.25, 21184.375, 21184.5, 21184.625, 21184.75,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hrPt/uas/gr/v20190429/uas_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010000-195812312100.nc
 time = 21184, 21184.125, 21184.25, 21184.375, 21184.5, 21184.625, 21184.75,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hrPt/vas/gr/v20190429/vas_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010000-195812312100.nc
 time = 21184, 21184.125, 21184.25, 21184.375, 21184.5, 21184.625, 21184.75,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hr/rlds/gr/v20190429/rlds_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010130-195812312230.nc
 time = 21184.0625, 21184.1875, 21184.3125, 21184.4375, 21184.5625,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/atmos/3hr/rsds/gr/v20190429/rsds_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010130-195812312230.nc
 time = 21184.0625, 21184.1875, 21184.3125, 21184.4375, 21184.5625,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/land/day/friver/gr/v20190429/friver_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_19580101-19581231.nc
 time = 21184.5, 21185.5, 21186.5, 21187.5, 21188.5, 21189.5, 21190.5,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/landIce/day/licalvf/gr/v20190429/licalvf_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_19580101-19581231.nc
 time = 21184.5, 21185.5, 21186.5, 21187.5, 21188.5, 21189.5, 21190.5,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/ocean/day/tos/gn/v20190429/tos_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gn_19580101-19581231.nc
 time = 21184.5, 21185.5, 21186.5, 21187.5, 21188.5, 21189.5, 21190.5,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/seaIce/3hrPt/siconca/gr/v20190429/siconca_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gr_195801010000-195812312100.nc
 time = 21184, 21184.125, 21184.25, 21184.375, 21184.5, 21184.625, 21184.75,
/g/data/qv56/replicas/input4MIPs/CMIP6/OMIP/MRI/MRI-JRA55-do-1-4-0/seaIce/day/siconc/gn/v20190429/siconc_input4MIPs_atmosphericState_OMIP_MRI-JRA55-do-1-4-0_gn_19580101-19581231.nc
 time = 21184.5, 21185.5, 21186.5, 21187.5, 21188.5, 21189.5, 21190.5,

The RYF time axes all start at 0 because the RYF data is given a new time axis, effectively applying an offset.

IAF data starts at 0.0625 day (5400s) for prra, prsn, rlds, rsds and 0.5 day (43200s) for friver and licalvf. So for consistency, should the offsets for these be -5400 and -43200 respectively, so they are all at 0, the same as RYF? (Instead of offsetting huss, psl, tas, uas, vas by +5400s.)

@ezhilsabareesh8
Copy link
Contributor

It makes more sense to set a negative offset for variables that start at 5400s and 43200s to align with RYF. I've set an offset of -5400 for prra, prsn, rlds, rsds and -43200 for friver and licalvf. Also set huss, psl, tas, uas, and vas back to zero. I've tested this, and it's working. Shall I push these changes to 1deg_jra55do_iaf_iss33?

@aekiss
Copy link
Contributor Author

aekiss commented Oct 24, 2023

Great, thanks @ezhilsabareesh8. It would be better to push this to a new branch based on 1deg_jra55do_iaf, since 1deg_jra55do_iaf_iss33 had merge conflicts.

@ezhilsabareesh8
Copy link
Contributor

Thanks @aekiss. I have pushed the changes to 1deg_jra55do_iaf branch in this commit 5fc754d

@aekiss
Copy link
Contributor Author

aekiss commented Oct 24, 2023

Thanks @ezhilsabareesh8 I've just updated the XML generators to match

@micaeljtoliveira
Copy link
Contributor

@aekiss Looks like this issue has been resolved. Can we close it?

@aekiss
Copy link
Contributor Author

aekiss commented Jan 16, 2024

yep!

@aekiss aekiss closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1deg_jra55do_iaf 1deg_jra55do_iaf configuration
Projects
None yet
Development

No branches or pull requests

3 participants