From cfe4d7bb1d812cec474bc38d1527c350428d38c3 Mon Sep 17 00:00:00 2001 From: Sean Bryan Date: Mon, 29 Jan 2024 10:25:05 +1100 Subject: [PATCH] Add comment regarding specifying the compiler for MPI --- packages/cable/package.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/cable/package.py b/packages/cable/package.py index ae4753f..4d34a65 100644 --- a/packages/cable/package.py +++ b/packages/cable/package.py @@ -39,6 +39,14 @@ def cmake_args(self): if self.spec.satisfies("+mpi"): args += [ self.define_from_variant("CABLE_MPI", "mpi"), + # TODO(Sean): we should let CMake find the MPI compiler instead + # of specifying it explicitly. However, this requires adding + # find_package(MPI) to the CMakeLists.txt file. This was not + # done in https://github.com/CABLE-LSM/CABLE/pull/200 so that + # we can demonstrate binary equivalence in the executables when + # transitioning from a Makefile based to a CMake based build + # system. Once find_package(MPI) is added, this file should be + # updated. self.define( "CMAKE_Fortran_COMPILER", self.spec["mpi"].mpifc,