Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringent Regression Tests #4

Open
cortner opened this issue Sep 2, 2021 · 4 comments
Open

Stringent Regression Tests #4

cortner opened this issue Sep 2, 2021 · 4 comments

Comments

@cortner
Copy link
Member

cortner commented Sep 2, 2021

@davkovacs

I think it would be great if we can produce a number of stringent regression tests (not part of the standard test set) where we download some existing training sets and ensure that future versions of the code can reproduce the accuracy and performance. This is not a short-term thing, but if as you say more people are starting to use ACE then we need to make sure that we really maintain the performance of the code across versions.

My group will help of course, but I think you might be the best person to produce the initial tests?

@cortner
Copy link
Member Author

cortner commented Sep 2, 2021

@gabor1 are there public links to some of your favourite training sets?

Generally - it would great to get your input on the design of these tests.

@gabor1
Copy link

gabor1 commented Sep 2, 2021 via email

@davkovacs
Copy link
Collaborator

I will create some when trying to reproduce ACE1 results with ACE2.

@cortner
Copy link
Member Author

cortner commented Jan 14, 2022

@david - @andresrossb and I have started implementing performance regression tests in ACE.jl; there are some very nice packages that allow us to do this conveniently, it is worth a look. I highly recommend including this here as well. (for the performance anyhow. Haven't looked at how to do the same for model accuracy.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants