Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maxiter for Bayesian Solvers #44

Closed
cortner opened this issue Mar 5, 2023 · 3 comments
Closed

Maxiter for Bayesian Solvers #44

cortner opened this issue Mar 5, 2023 · 3 comments
Labels
urgent

Comments

@cortner
Copy link
Member

cortner commented Mar 5, 2023

LSQR has a maxiter parameter but the Bayesian solvers do not. For some problems they just seem to not converge (cf Slack discussion). They should all get this parameter please, and then they should fail with a nice user-friendly message, something along the lines of "even when the solver hasn't converged the quality of the solution may be good, please test this before changing solver parameters"
@cortner cortner added the urgent label Mar 5, 2023
@cortner
Copy link
Member Author

cortner commented Mar 5, 2023

I think once this is added we can rerun our benchmarks with the pure-Julia BLR

@wcwitt
Copy link
Collaborator

wcwitt commented Mar 6, 2023

Thanks - completely agree

@wcwitt
Copy link
Collaborator

wcwitt commented Mar 7, 2023

This was already on the todo list here, so I'm going to close and focus on that issue.

@wcwitt wcwitt closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cortner @wcwitt