Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress in assembly #60

Open
cortner opened this issue Jul 20, 2023 · 4 comments
Open

Show progress in assembly #60

cortner opened this issue Jul 20, 2023 · 4 comments

Comments

@cortner
Copy link
Member

cortner commented Jul 20, 2023

Does the showprogress line

    @showprogress pmap(packets) do p

correctly represent progress? I.e. does it account for the fact that some structures are much bigger than others and more expensive to assemble?

Note in #54 I do this manually.

My evidence for this is that my distributed assembly starts with > 1.5h, then drops to ca 1h for a while and then completes in around 25 minutes total.

@wcwitt
Copy link
Collaborator

wcwitt commented Jul 20, 2023

I've been claiming this works for months, but it turns out I was mistaken, sorry.

I interpreted this, from the docs, to mean @showprogress uses length as a cost function:

The @showprogress macro wraps a for loop, comprehension, @distributed for loop, or map/pmap/reduce as long as the object being iterated over implements the length method

Which is why I set Base.length(d::DataPacket) = count_observations(d.data). But it doesn't work that way after all.

My latest experiments use your approach anyway - we can close this once they're merged.

@cortner
Copy link
Member Author

cortner commented Jul 27, 2023

related to #2

@cortner
Copy link
Member Author

cortner commented Aug 18, 2023

can this be closed now?

@wcwitt
Copy link
Collaborator

wcwitt commented Aug 18, 2023

no, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants