Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish New Lsq Assembly #48

Open
3 tasks
cortner opened this issue Sep 20, 2023 · 1 comment
Open
3 tasks

Finish New Lsq Assembly #48

cortner opened this issue Sep 20, 2023 · 1 comment

Comments

@cortner
Copy link
Member

cortner commented Sep 20, 2023 •
edited
Loading

  • Allow general weights dictionary
  • PR to ACEpotentials to allow AtomsBase data as input to acefit!
  • PR to ACEfit to replace the assemble implementation (tbc)
@cortner cortner changed the title New Lsq Assembly Finish New Lsq Assembly Sep 20, 2023
@cortner
Copy link
Member Author

cortner commented Sep 20, 2023

Re point on ACEpotentials: the line

https://github.com/ACEsuit/ACEpotentials.jl/blob/a1dc2e8409113f198ba4003f0c5a6911be53d2f1/src/model.jl#L63

needs to be replaced with a dispatch depending on whether raw_data is JuLIP or AtomsBase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cortner