Skip to content

Better functions for defining rin0cuts in new ACE model #201

Open
@CheukHinHoJerry

Description

@CheukHinHoJerry

Currently the user has to define a a SMatrix with something like

elements = (:Si, :O)
NZ = length(elements)
function make_rin0cut(zi, zj) 
   r0 = ACE1x.get_r0(zi, zj)
   return (rin = 0.0, r0 = r0, rcut = 6.5)
end

rin0cuts = SMatrix{NZ, NZ}([make_rin0cut(zi, zj) for zi in elements, zj in elements])

.

This is not convenient/user-friendly at all. To be discussed how we should do this better.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions