Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add parameters to optimizer #525

Open
LarsSchaaf opened this issue Jul 19, 2024 · 0 comments
Open

Automatically add parameters to optimizer #525

LarsSchaaf opened this issue Jul 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@LarsSchaaf
Copy link
Collaborator

Current Behaviour
If a new parameter is added to the model, the parameters dont get trained. This is because currently only certain parameters are explicitly added to the optimiser. This is done to be able to add different weight decays for specific parameters.

Desired behaviour
When developing and adding new Modules with new parameters one expects these to be trained during training. Hence a function that automatically adds any parameters that don't have explicit optimisation parameters defined to be added to the optimiser with default settings.

Alternatives
Printing a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants