Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate code in map observers #2446

Closed
addisoncrump opened this issue Jul 25, 2024 · 4 comments
Closed

Deduplicate code in map observers #2446

addisoncrump opened this issue Jul 25, 2024 · 4 comments
Labels
cleanup Reducing our technical debt

Comments

@addisoncrump
Copy link
Collaborator

Nearly all of the MapObserver implementations seem to be copy/pasted, and there is a lot of old code that is no longer needed. Duplicated code should be extracted to common methods where >5 lines.

@addisoncrump addisoncrump added the cleanup Reducing our technical debt label Jul 25, 2024
@sarthakvyas16
Copy link

i will work on this issue please assign me this issue.

@domenukk
Copy link
Member

We don't really assign issues, but feel free to work on it. Thanks! :)

@domenukk
Copy link
Member

Depends on the quality of your PRs and you proposal

@tokatoka
Copy link
Member

tokatoka commented Nov 4, 2024

this turned out to be impossible because Deref didn't work?

@tokatoka tokatoka closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Reducing our technical debt
Projects
None yet
Development

No branches or pull requests

4 participants