Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] : Rename package to AFMReader #43

Closed
10 tasks done
SylviaWhittle opened this issue May 2, 2024 · 4 comments
Closed
10 tasks done

[feature] : Rename package to AFMReader #43

SylviaWhittle opened this issue May 2, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@SylviaWhittle
Copy link
Collaborator

SylviaWhittle commented May 2, 2024

Is your feature request related to a problem?

It has been suggested by Alice that this repo be renamed to AFMFileFormats as this may be more representative. Is this possible? Are there metadata that cannot change? Likely the PyPI identifier?

Describe the solution you would like.

Rename the repo to afmfileformats along with the PyPI identifier if possible. Discuss before doing it.

Describe the alternatives you have considered.

Not renaming it if this isn't possible or if remnants of the old name would cause confusion for users.

Sample Image

No response

Additional context

No response

Tasks

  • Rename GitHub repository (and update local clones configuration of origin to point to the renamed repository).
  • Update package...
    • pyproject.toml
    • CITATION.cff (don't currently have one though!).
    • topofileformats > AFMReader for package directory.
    • Update all import topofileformats to import AFMReader (files include AFMReader/*.py, tests/test_*.py, README.md, examples/example_01.ipynb).
  • Upload renamed package AFMReader to PyPI
  • Update topofileformats to have a single dependency AFMReader so that the new package is installed if anyone tries to install the old package.
    • Publish updated package to PyPI. Opted to delete topofileformats from PyPI completed by @SylviaWhittle 2024-06-05 15:22
  • Update TopoStats to depend on AFMReader rather than topofileformats see Migrate IO class from TopoStats #22 instead.
@SylviaWhittle SylviaWhittle added the enhancement New feature or request label May 2, 2024
@ns-rse
Copy link
Collaborator

ns-rse commented May 3, 2024

I've mentioned before I think the package name could be more descriptive.

I'm not a fan of the fileformats component as that implies it relates to a definition of file formats or file specifications.

What the package is doing is reading files of different formats so my suggestion for an appropriate name would be AFMReader.

With regards to how to rename...

  • Rename GitHub repository (and update local clones configuration of origin to point to the renamed repository).
  • Update package Metadata in...
    • pyproject.toml
    • CITATION.cff (don't currently have one though!).
  • Upload renamed package AFMReader to PyPI
  • Update topofileformats to have a single dependency AFMReader so that the new package is installed if anyone tries to install the old package.
  • Update TopoStats to depend on AFMReader rather than topofileformats

With PyPI you can't rename packages. You have to upload a new package and have the old one point to the new. The simonw/pypi-rename: Cookiecutter template for creating renamed PyPI packages can help here it seems.

Technically the new one is a very simple package that has a single dependency, the new package so when people pip install topofileformats it would install AFMReader (if that is the name of the new package).

A brief search threw up afmformats which looks like it is a similar package. There may be others and perhaps looking to collaborate might be something to consider (e.g. we're using the igor2 and pySPM packages).

@ns-rse ns-rse self-assigned this May 7, 2024
@ns-rse ns-rse changed the title [feature] : Rename package to afmfileformats [feature] : Rename package to AFMReader May 7, 2024
@ns-rse
Copy link
Collaborator

ns-rse commented May 7, 2024

If you already have a git clone of this repository and wish to continue using it now that it has been renamed you need to edit the .git/config file in the repository to change url = [email protected]:AFM-SPM/topofileformats.git to url = [email protected]:AFM-SPM/AFMReader.git...

Before

[remote "origin"]
	url = [email protected]:AFM-SPM/AFMReader.git

After

[remote "origin"]
	url = [email protected]:AFM-SPM/topofileformats.git

Not Essential but Sensible

It's not essential but it would be sensible to also rename the cloned directory. Assuming you are on the command line and the path to the cloned directory is ~/work/git/hub/AFM-SPM/topofileformats you should change it to ~/work/git/hub/AFM-SPM/AFMReader.

mv ~/work/git/hub/AFM-SPM/topofileformats ~/work/git/hub/AFM-SPM/AFMReader

@alicepyne
Copy link
Member

Is this now done?

ns-rse added a commit to AFM-SPM/topofileformats that referenced this issue May 29, 2024
With the consensus to rename `topofileformats` > `AFMReader` we need to make a final release based on this commit of
`topofileformats` to PyPI which should 🤞 mean that any attempt to install `topofileformats` from PyPI
will simply pull in the renamed `AFMReader` package instead.

For further details see [AFMReader Issue 43](AFM-SPM/AFMReader#43).
@ns-rse
Copy link
Collaborator

ns-rse commented Jun 5, 2024

Closing, AFMReader v0.0.1 is on PyPI and topofileformats has been removed from PyPI to avoid confusion.

@ns-rse ns-rse closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants