Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lane_detector independent of grass removal #81

Open
shivamvats opened this issue Oct 23, 2015 · 2 comments
Open

Make lane_detector independent of grass removal #81

shivamvats opened this issue Oct 23, 2015 · 2 comments
Assignees

Comments

@shivamvats
Copy link
Member

minimal

Lane detection and grass removal are logically separate and lane detection need not know about how grass removal is done. Hence, there should be a separate abstract class for data pre-processing, from which grass removal will inherit.

@todivasudha
Copy link
Contributor

@shivamvats
Lane detection involves the following :
data pre-processing => shadow removal => inverse perspective transform => grass removal => obstacle removal => lane detection
So do we make a separate class for each of them?
Also the functions seperateLanes() and fixBrokenLanes() have been declared within the class but not defined anywhere.

@shivamvats
Copy link
Member Author

@todivasudha Aren't shadow removal, IPT etc types of data pre-processing?
What I am thinking is to have two base classes - pre-processing and lane detection. Rest can inherit from these. The idea is that if later I want to use a different pre-processing technique, I don't have to change any code, but I can inherit from a base class.

Do you have any ideas for base-classes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants