Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SDC guidance for researchers and checkers #71

Open
rpreen opened this issue May 13, 2023 · 3 comments
Open

Adding SDC guidance for researchers and checkers #71

rpreen opened this issue May 13, 2023 · 3 comments
Labels
enhancement New feature or request Q for WP1

Comments

@rpreen
Copy link
Collaborator

rpreen commented May 13, 2023

Assuming the availability of SDC guidance such as in this handbook or as is being produced in WP1 (e.g., statistic type, description, requirements, disclosure issues, mitigation, possibly TRE specific rules, etc.) this information needs to be made available to both researchers and TRE checkers. So the question is how best to make this available for ease of access, maintenance, and including ACRO examples.

Should this information be made available on an independent website or included directly within ACRO documentation? ACRO documentation could simply link to the relevant part of an external website? How coupled should the guidance be with ACRO implementation?

Should the checker GUI be able to directly search/display guidance or just provide links?

Currently we attempt to include the whole ACRO command within the JSON output, but we should also include a simplified form of either (a) the function name (e.g., "function": "ols") or (b) a type (e.g., "type": "regression") so that the GUI can then use this to decide what SDC guidance to reference for more information?

@jim-smith jim-smith added enhancement New feature or request Sprint2 labels Jun 22, 2023
@rpreen
Copy link
Collaborator Author

rpreen commented Jun 29, 2023

As of #89 JSON output now includes a field named "type" which is:

  • "table" for crosstab() and pivot_table()
  • "regression" for ols(), olsr(), probit(), probitr(), logit(), logitr()
  • "custom" for custom_output()

Each also contains a "properties" field, which is a dictionary that contains a "method" field (as well as output-specific entries) for each. The "method" may be:

  • "crosstab", "pivot_table", "ols", "olsr", "probit", "probitr", "logit", "logitr", "custom"

@jim-smith
Copy link
Contributor

@rpreen just occurred t me that for researchers we could have a function describe_risk(family:str) or describe_risk(output:str) that they could call to get more nicely formatted and detailed feedback and help than just splurging it out via INFO logging. (although we should still do that as well)

@jim-smith jim-smith removed the Sprint3 label Oct 3, 2023
@jim-smith
Copy link
Contributor

Think that we have everything we nee to do this in place technically.
However, am placing on hold for now while we get the excel spreadsheet of risks from WP1 into a more structured document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Q for WP1
Projects
Status: No status
Development

No branches or pull requests

2 participants