Add basic support for rendering code and other preformatted text #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works by having a list of file extensions to render.
lucyb
approved these changes
Oct 20, 2023
| @@ -11,13 +11,14 @@ export const isCsv = (ext) => ext.toLowerCase() === "csv"; | |||
| export const isImg = (ext) => | |||
| ["gif", "jpg", "jpeg", "png", "svg"].includes(ext.toLowerCase()); | |||
|
|
|||
| export const TEXT_TYPES = ["txt", "md", "py", "yaml", "R", "log"]; | |||
| /** | |||
| * Confirm if file is .txt | |||
| * @param {string} ext - file extension | |||
| * @returns {boolean} | |||
| */ | |||
| export function isTxt(ext) { | |||
There was a problem hiding this comment.
I'd be tempted to rename the function as isText to make it clearer that it's not just checking for a .txt extension.
There was a problem hiding this comment.
Good idea, will do
| @@ -11,13 +11,14 @@ export const isCsv = (ext) => ext.toLowerCase() === "csv"; | |||
| export const isImg = (ext) => | |||
| ["gif", "jpg", "jpeg", "png", "svg"].includes(ext.toLowerCase()); | |||
|
|
|||
| export const TEXT_TYPES = ["txt", "md", "py", "yaml", "R", "log"]; | |||
| /** | |||
| * Confirm if file is .txt | |||
There was a problem hiding this comment.
This code comment is now out of date, as it's no longer just checking for ".txt"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works by having a list of file extensions to render.
Fixes #236