Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use edm4hep::labels::CellIDEncoding instead of "CellIDEncoding" #1333

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Oct 17, 2024

BEGINRELEASENOTES

  • Use edm4hep::labels::CellIDEncoding instead of "CellIDEncoding"
  • Use podio::collMetadataParamName instead of hardcoding the convention of adding __

ENDRELEASENOTES

See https://github.com/key4hep/EDM4hep/blob/22e85d79eca00bbd4eb479a536f90b86e76ea726/include/edm4hep/Constants.h#L29. This is the only place I could find that is related to EDM4hep.

Copy link

github-actions bot commented Oct 17, 2024

Test Results

   14 files     14 suites   5h 41m 28s ⏱️
  366 tests   365 ✅ 0 💤 1 ❌
2 517 runs  2 516 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 0dd4383.

♻️ This comment has been updated with latest results.

@andresailer andresailer merged commit e105389 into AIDASoft:master Oct 17, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants