Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema evolution script does not flag some evolutions as impossible #563

Closed
tmadlener opened this issue Feb 22, 2024 · 0 comments · Fixed by #622
Closed

Schema evolution script does not flag some evolutions as impossible #563

tmadlener opened this issue Feb 22, 2024 · 0 comments · Fixed by #622
Assignees

Comments

@tmadlener
Copy link
Collaborator

The podio_schema_evolution.py script should catch problematic schema evolutions before they are actually commited. The recent swtich from Vector3f to Vector3d in EDM4hep was one of these changes as it is not supported by default by ROOT. However, the output of the current version of the script simply states the following:

$ python3 ~/work/AIDASoft/podio/python/podio_schema_evolution.py edm4hep.yaml edm4hep_float_mom.yaml 
Comparing datamodel versions 1 and 1
Detected 2 schema changes:
 - 'edm4hep::MCParticle.momentum' changed type from '+                    'edm4hep::Vector3f to edm4hep::Vector3d
 - 'edm4hep::MCParticle.momentumAtEndpoint' changed type from '+                    'edm4hep::Vector3f to edm4hep::Vector3d
{}

This evolution should be flagged as impossible.

Related PRs / issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants