Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from tuple to struct for storing metadata of stored collections #705

Open
tmadlener opened this issue Nov 12, 2024 · 2 comments · May be fixed by #711
Open

Change from tuple to struct for storing metadata of stored collections #705

tmadlener opened this issue Nov 12, 2024 · 2 comments · May be fixed by #711

Comments

@tmadlener
Copy link
Collaborator

Currently we use a std::tuple to store some metatdata related to collections:

podio/include/podio/utilities/RootHelpers.h

Lines 18 to 21 in 5afdefd

// A collection of additional information that describes the collection: the
// collectionID, the collection (data) type, whether it is a subset
// collection, and its schema version
using CollectionWriteInfoT = std::tuple<uint32_t, std::string, bool, unsigned int>;

This makes it hard to read via julia and also from a maintainability point of view it would be nicer, if this was something like

struct CollectionWriteInfo {
  uint32_t collectionID;
  std::string dataType;
  bool isSubset;
  unsigned int schemaVersion;
};

@peremato I suppose something along these lines should work?
@peremato
Copy link
Collaborator

What about adding also the collection name? In this case you need only one branch for all information.

@tmadlener
Copy link
Collaborator Author

Yeah, I could add that. I have to check how we can deduplicate some parts, because that information is also stored via the CollectionIDTable.

@tmadlener tmadlener linked a pull request Nov 20, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Store the collection information in a struct instead of a tuple tmadlener/podio
2 participants
@peremato @tmadlener