-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Firefox browser compatibility #707
feat: add support for Firefox browser compatibility #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible, can you create a file for selenium interactions. Ensure selenium methods works for both browsers.
def is_scrollable(element):
def scroll_slow(driver, scrollable_element, start=0, end=3600, step=300, reverse=False):
@Tverous can make any comment on issue 61, we can assign this issue to you. |
@surapuramakhil, would you mind reviewing for the refactored code? Thanks! |
I will wait to review until after @surapuramakhil requested changes and the conflicts are resolved. |
@surapuramakhil, let me know if you want me to resolve the conflict or add more descriptions of the refactored code first. thanks. |
@Tverous resolve the conflicts |
conflicts resolved |
@sarob please can you do a review? |
yes, Kindly resolve confits. Without that we won't be able to merge it into the release branch. join discord release channel: https://discord.gg/gjDwqhXZ52 |
passing this PR to @sarob |
Totally agree with @surapuramakhil comment. @Tverous let me know what do you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one change is required. Single source of truth one.
@Tverous any updates? |
based on this https://github.com/AIHawk-FOSS/Auto_Jobs_Applier_AI_Agent/pull/707/files/03f387f32256d2fa32d407f892c29a45e09e0665#r1849167202 It looks like a senior dev needs to contribute to remove the current cyclic dependency. |
Desc
Resolving #61
Extend browser compatibility to support Firefox as an alternative to Chrome.
To specify the browser type explicitly, use the
--browser firefox
option when runningmain.py
.