Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading preequilibration failure messages #2178

Closed
dweindl opened this issue Oct 17, 2023 · 0 comments · Fixed by #2181
Closed

Fix misleading preequilibration failure messages #2178

dweindl opened this issue Oct 17, 2023 · 0 comments · Fixed by #2181
Assignees
@dweindl
Labels
c++

Comments

@dweindl
Copy link
Member

dweindl commented Oct 17, 2023

When preequilibration (or finding a steadystate in general) fails, SteadystateProblem::handleSteadyStateFailure currently produces AMICI simulation failed: Steady state computation failed. First run of Newton solver failed. Simulation to steady state failed: No convergence was achieved. Second run of Newton solver failed., even in cases where no Newton solve or no simulation was attempted. This is confusing and needs to be changed.
@dweindl dweindl added the c++ label Oct 17, 2023
@dweindl dweindl self-assigned this Oct 25, 2023
dweindl added a commit that referenced this issue Oct 25, 2023
@dweindl
Fix Fix misleading preequilibration failure messages
e7dd6f5 
When preequilibration (or finding a steadystate in general) fails,
`SteadystateProblem::handleSteadyStateFailure` produced
`AMICI simulation failed: Steady state computation failed. First run of Newton solver failed. Simulation to steady state failed: No convergence was achieved. Second run of Newton solver failed.`,
even in cases where no Newton solve or no simulation was attempted.
This is confusing and is changed here, so that the message now reflects what has actually happened.

Closes #2178
@dweindl dweindl mentioned this issue Oct 25, 2023
Merged
@dweindl dweindl linked a pull request Nov 20, 2023 that will close this issue
Fix misleading preequilibration failure messages #2181
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix misleading preequilibration failure messages AMICI-dev/AMICI
1 participant
@dweindl