From 9f2bd19e7b81547cc8d2bf8b84e5672bcde0d1a5 Mon Sep 17 00:00:00 2001 From: Daniel Weindl Date: Mon, 9 Dec 2024 10:26:49 +0100 Subject: [PATCH 1/2] Tests: Skip llh test for Isensee_JCB2018 Until it has been decided which model/dataset is the correct one, and the expected llh is updated accordingly. See https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/pull/253 --- tests/benchmark-models/test_petab_benchmark.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/benchmark-models/test_petab_benchmark.py b/tests/benchmark-models/test_petab_benchmark.py index 7c70015a8c..4a63d8bfda 100644 --- a/tests/benchmark-models/test_petab_benchmark.py +++ b/tests/benchmark-models/test_petab_benchmark.py @@ -123,7 +123,9 @@ "Elowitz_Nature2000", "Fiedler_BMCSystBiol2016", "Fujita_SciSignal2010", - "Isensee_JCB2018", + # Excluded until https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/pull/253 + # is sorted out + # "Isensee_JCB2018", "Lucarelli_CellSystems2018", "Schwen_PONE2014", "Smith_BMCSystBiol2013", From 4a234311cb2ffc4e87678c2f2bdaff13d1c58649 Mon Sep 17 00:00:00 2001 From: Daniel Weindl Date: Mon, 9 Dec 2024 11:28:08 +0100 Subject: [PATCH 2/2] fix broken pytest invocation --- .github/workflows/test_benchmark_collection_models.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_benchmark_collection_models.yml b/.github/workflows/test_benchmark_collection_models.yml index e68ec1518b..77470367d7 100644 --- a/.github/workflows/test_benchmark_collection_models.yml +++ b/.github/workflows/test_benchmark_collection_models.yml @@ -67,7 +67,7 @@ jobs: AMICI_PARALLEL_COMPILE: "" run: | cd tests/benchmark-models && pytest \ - --durations=10 + --durations=10 \ --cov=amici \ --cov-report=xml:"coverage_py.xml" \ --cov-append \