Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potentially more issues with reties and amr.subcycle_mode = None #2823

Closed
zingale opened this issue Apr 12, 2024 · 2 comments
Closed

potentially more issues with reties and amr.subcycle_mode = None #2823

zingale opened this issue Apr 12, 2024 · 2 comments

Comments

@zingale
Copy link
Member

zingale commented Apr 12, 2024

It looks like we need to update retry_advance_ctu() to do save_data_for_retry() and zero out the fluxes on all levels if we are not doing AMR subcycling.

We probably also need to update the time level stuff after the subcycling is complete in subcycle_advance_ctu()
@zingale
Copy link
Member Author

zingale commented Apr 20, 2024

these are fixed in #2824

@zingale
Copy link
Member Author

zingale commented Apr 22, 2024

this seems to be fixed now

@zingale zingale closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zingale