Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch Strang from T to e integration #258

Open
zingale opened this issue Feb 3, 2021 · 0 comments
Open

switch Strang from T to e integration #258

zingale opened this issue Feb 3, 2021 · 0 comments

Comments

@zingale
Copy link
Member

zingale commented Feb 3, 2021

This issue serves to track Microphysics AMReX-Astro/Microphysics#496 as it applies to MAESTROeX.

For Strang integration, we will switch from integrating (T, X_k) to integrating (e, X_k) in the reaction networks. This will require us to call the EOS every righthand side call, but testing has shown that this is not a performance issue (and in some cases, we speed up). Further, once this is in, we will template the EOS call to use eos_re_t, which further cuts down on the EOS expense.

Overall this is more accurate than what we were doing. It also reduces the size of the integration system (and linear algebra).

For MAESTROeX however, we might consider adding the option to have the Strang integration variables be (h, X_k), instead of (e, X_k), since enthalpy is more natural for low Mach flows.

The plan is to merge this before 21.03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant