Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing optional properties in PATCH requests? #47

Open
garethsb opened this issue Nov 29, 2019 · 1 comment
Open

Removing optional properties in PATCH requests? #47

garethsb opened this issue Nov 29, 2019 · 1 comment
Milestone
v2.0

Comments

@garethsb
Copy link
Contributor

garethsb commented Nov 29, 2019 •
edited
Loading

Related to #46...

E.g. can a client PATCH an Endpoint or a Network Flow to remove their "label" or other optional properties (e.g. Endpoint "max_bandwidth")?

This hasn't come up in e.g. IS-05 because there are no optional "transport_params", they just may support null.

We could support patching null to remove an optional property, because optional properties that also allow null are unlikely. This would also actually be more in line with RFC 7386 JSON Merge Patch.
@garethsb
Copy link
Contributor Author

Another option is to do this in v1.1 by making these properties required but allowing null.

@garethsb garethsb added this to the v1.1 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@garethsb