Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on sender side sequence diagram #62

Closed
VenkateswaranJ opened this issue May 25, 2023 · 3 comments
Closed

Clarification on sender side sequence diagram #62

VenkateswaranJ opened this issue May 25, 2023 · 3 comments
Assignees

Comments

@VenkateswaranJ
Copy link

https://github.com/AMWA-TV/is-08/blob/v1.0.x/docs/images/sequence-diagrams/sender-sequence.png
In the above IS-08 sender-side sequence diagram, the fetch request resolves ReceiverId to Input,
it should be resolves SendeId to Output isn't it? or am I missing something here?

@garethsb
Copy link
Contributor

I'm confused by the diagram as well... If you were correct, then it would be the SenderId that is already known, in which case the Controller would need to identify the associated Flow, and its associated Source, and use its SourceId to resolve the associated Output to be able to set up the channel map via IS-08.

But given the following interactions shown with the Query API, I don't think that's what is intended.

I think the assumption in the diagram is that the User wants to start by changing the channel map (associated with a Receiver, but I agree I don't think that's right!) and then following the Output in the other direction than above... via its SourceId and then via the Query API to a related Sender.

That doesn't make sense to me as a workflow.

@peterbrightwell, what are we missing? Let's discuss in @AMWA-TV/nmos-architecture-review team.

@peterbrightwell
Copy link
Contributor

Architecture Review Group review: place on backlog

@garethsb
Copy link
Contributor

ARG: simplest fix to make the diagram correct is to change like this...

< Fetch IO information and resolve the Receiver ID to an Input in the API, enumerate channels and discover permissible routing
----
> Fetch IO information and resolve the Source ID to an Output in the API, enumerate channels and discover permissible routing

The diagram then makes sense if the Client is starting from a specific Source ID.

Two more likely workflows seem to be:

  1. the Client is first setting up the channel mapping for a specific Output, then arranging to transmit that via a Sender to a Receiver; in this case the Client resolves the Output to its Source ID, and then proceeds as in the diagram, discovering the associated Flow and then Sender, in order to have that Output transmitted to a Receiver
  2. the Client is starts from a specific Sender, and before configuring it to transmit to a Receiver, discovers the associated Flow and then Source, before resolving the Source ID to an Output

Either of these would require slightly larger changes to the diagram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants