3차 세미나 #6
Open
3차 세미나 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hyunjinn
reviewed
Dec 17, 2024
There was a problem hiding this comment.
SignupRequest랑은 다르게 이곳에는 @NotNull(message = "이름을 입력해주세요.") 처리를 안해주신 이유가 있을까용?
2hyunjinn
reviewed
Dec 17, 2024
| import org.sopt.diary.member.domain.Member; | ||
|
|
||
| public record SignupRequest( | ||
| @NotNull(message = "이름을 입력해주세요.") |
There was a problem hiding this comment.
@NotBlank가 아니라 @NotNull로 설정하신 이유가 뭔가요?!
저는 이름에 공백도 안된다고 생각해서 @NotBlank로 처리했는데, @NotNull로 처리하면 뭐가 더 좋은 건가용
2hyunjinn
reviewed
Dec 17, 2024
Comment on lines
+29
to
+32
| public Member(String username, String password, String nickname, Integer age) { | ||
| this(null, username, password, nickname, age); | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️ Issue Number
🚩 Summary