Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change how modules are enabled #39

Open
otakup0pe opened this issue Apr 3, 2015 · 3 comments
Open

change how modules are enabled #39

otakup0pe opened this issue Apr 3, 2015 · 3 comments

Comments

@otakup0pe
Copy link
Member

Currently we enable extra modules by specifying the full string that is passed to configure. It would be much cleaner to specify them by a simple bool. As part of this we also may wish to revisit which modules are enabled by default.

Compare the two following YAML snippets.

nginx_source_modules_included:
  http_stub_status_module: "--with-http_stub_status_module"

nginx_source_modules_included:
  http_stub_status_module: yes
@soupdiver
Copy link
Contributor

Good idea! 👍
I also felt the current way isn't optimal but so far didn't thought about it much further.

@otakup0pe otakup0pe changed the title change how modules are enable change how modules are enabled Apr 5, 2015
@AgDude
Copy link

AgDude commented Jul 22, 2015

For modules which are part of the nginx source, what about including them with a simple list. Lots of the modules listed in the docs http://nginx.org/en/docs/ are not included by default.

nginx_source_modules:
  - http_stub_status_module
  - ngx_http_perl_module

Any of these modules are included by prepending the module name with --with- as a build option.

@soupdiver
Copy link
Contributor

With the idea from @AgDude we could avoid to have an extra mapping from the bool values @otakup0pe suggested.
Like this idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants