Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy search only finds matches within first 240 chars #490

Open
mwilmes opened this issue Jan 13, 2025 · 3 comments · May be fixed by #510
Open

Fuzzy search only finds matches within first 240 chars #490

mwilmes opened this issue Jan 13, 2025 · 3 comments · May be fixed by #510
Assignees
Milestone

Comments

@mwilmes
Copy link

mwilmes commented Jan 13, 2025

With the default Fuse.js settings in overview.tsx search matches are only considered within 240 characters from the start.

It might be useful to either make the search settings configurable or using "ignoreLocation: true" by default.

To illustrate, consider the following options:

location defaults to 0
distance defaults to 100
threshold defaults to 0.6
With the above options, for something to be considered a match, it would have to be within (threshold) 0.6 x (distance) 100 = 60 characters away from the expected location 0.

See also:

https://www.fusejs.io/concepts/scoring-theory.html
https://www.fusejs.io/api/options.html#ignorelocation

@mathiasschopmans
Copy link
Contributor

Thanks for raising this, @mwilmes.

The decision to limit the search to the first 240 characters was intentional by me to ensure performance remains acceptable on lower-end devices, such as budget smartphones. Expanding the search scope significantly increases the computational cost, which could negatively impact user experience on weaker hardware.

That said, we see the value in making this configurable. We’ll consider adding an option in the config.json to allow customization of the search behavior while keeping a reasonable default for performance reasons.

Feel free to share any specific use cases where this limitation is causing issues!

@mwilmes
Copy link
Author

mwilmes commented Mar 3, 2025

Thanks for the reply, @mathiasschopmans

We especially like your radar for properly accommodating more detail in the individual entries than other radars. Regarding the search the radar's prospect gets elevated if one not only just searches for technology names but actually searches for known projects or even names. Searching for what your product xyz uses? Search for it. Remember that guy who talked about some fancy stuff they're trying out? Search for his name. This can make the radar an invaluable asset for a bigger community of architects, engineers and developers. Something that makes people re-visit it and and contribute to more often.

It's just that once you are a bit more verbose on the entries then things like names, projects etc. might be beyond the first 240 characters. So making it configurable would prevent us from maintaining a fork.

@mathiasschopmans
Copy link
Contributor

@MalibusParty takes care.

@MalibusParty MalibusParty self-assigned this Mar 13, 2025
@MalibusParty MalibusParty linked a pull request Mar 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants