Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Use WalletConnect's Web3Modal to handle wallet connection in clientAnonymousVoting #29

Closed
adityabhattad2021 opened this issue Mar 22, 2024 · 1 comment

Comments

@adityabhattad2021
Copy link

Why?

  • Using custom register logic is quite cumbersome. We have to handle all the logic ourselves, from detecting Ethereum to handling cases when the user's browser doesn't have a wallet present. Additionally, if the user wants to connect with a different wallet other than MetaMask, Web3Modal handles it all by itself.
  • The useWeb3ModalAccount hook provided by Web3Modal proves to be useful in multiple places in the codebase. It allows us to avoid writing code to fetch the address from the browser wallet. The hook helps us easily manage the address globally throughout the application, resulting in less error-prone and cleaner code.
@12sachingupta
Copy link

These are the limitations of the Web3Modal

Vendor Lock-in:
By tightly integrating with Web3Modal, you may find yourself locked into its ecosystem. If you later decide to switch to a different wallet integration solution or implement custom logic, you may face challenges migrating away from Web3Modal.

Documentation and Support:
While Web3Modal provides documentation and community support, the level of assistance may not be as extensive as official Ethereum or Web3.js documentation. Depending on your team's expertise and the complexity of your requirements, you may encounter difficulties troubleshooting issues or finding solutions to advanced problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants