Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter rooms by Tags #197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShivamMenda
Copy link
Contributor

Description

This pull request introduces a feature to filter rooms by the tags given by the user.

Fixes #188

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

filter-rooms.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@ShivamMenda
Copy link
Contributor Author

@chandansgowda I have implemented the feature. Let me know if any other changes are required.

@chandansgowda chandansgowda added enhancement New feature or request aip-2023 Part of AOSSIE Internship Program 2023 labels Oct 16, 2023
Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job till here @ShivamMenda
I see that you are selecting two or three tags together and filtering. Make it as one tag. also improve the UI which comes below the app bar.

@ShivamMenda
Copy link
Contributor Author

@chandansgowda selecting one tag which means, the user should be able to select only one tag at a time or there should be options of only one tag? Also regarding the UI where do you want me to keep the filter button?

@chandansgowda
Copy link
Member

@ShivamMenda Please contact appwrite team and get an idea of an efficient database design for the same.

@ShivamMenda
Copy link
Contributor Author

@chandansgowda Sire will discuss with them.

@chandansgowda
Copy link
Member

Any updates @ShivamMenda ?

@ShivamMenda
Copy link
Contributor Author

@chandansgowda dm'd a few people from the appwrite server. Did not get a reply. I'll put up a message in the flutter channel directly today. Will keep you posted.

@chandansgowda
Copy link
Member

@ShivamMenda You can raise a ticket in their support channel.

@ShivamMenda
Copy link
Contributor Author

@chandansgowda will do that.

@Aarush-Acharya Aarush-Acharya added the ua unattended label May 24, 2024
@Aarush-Acharya
Copy link
Contributor

Hey @ShivamMenda great work, cool new addition

Please do make the requested changes and we will merge it asap

@Aarush-Acharya
Copy link
Contributor

Aarush-Acharya commented May 24, 2024

Also @ShivamMenda is the appwrite collection and system structure already implemented for this feature ?? Please do give me an update on were are we on this

@Aarush-Acharya Aarush-Acharya added attended This PR was attended by a Reviewer and removed ua unattended labels May 24, 2024
@ShivamMenda
Copy link
Contributor Author

@Aarush-Acharya I had proposed this issue long time back, and had implemented it to an extent, but I think we need to discuss on how we can change the room db structure a little so that this feature can be implemented in the existing codebase.

@Aarush-Acharya
Copy link
Contributor

Understood @ShivamMenda will look into it

@Aarush-Acharya
Copy link
Contributor

Aarush-Acharya commented Jul 16, 2024

Hey @ShivamMenda, please do let me know what do you propose as an alteration of the current room db structure for it to work

Also now as we have the entire backend hosted locally please do, change the structure for yourself local and have it done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aip-2023 Part of AOSSIE Internship Program 2023 attended This PR was attended by a Reviewer enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter rooms by tag in room list
3 participants