Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added password validator on the login screen. #257

Closed
wants to merge 1 commit into from
Closed

Added password validator on the login screen. #257

wants to merge 1 commit into from

Conversation

Mehul-Kumar-27
Copy link

@Mehul-Kumar-27 Mehul-Kumar-27 commented Feb 7, 2024 •
edited
Loading

Description

Added the password validator at the login screen for convince of the user. The validations are same as that used in the signup screen.

Fixes #223

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

validator1
validator2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@Aarush-Acharya Aarush-Acharya added the attended This PR was attended by a Reviewer label May 22, 2024
@vrundraval24
Copy link
Contributor

vrundraval24 commented May 22, 2024 •
edited by Aarush-Acharya
Loading

hey, @Mehul-Kumar-27 good work.

According to issue #223
Yes, we should check password validity before making the API call for login to Appwrite, so if on login page after user has entered the password and presses on login. We need to run the validation checks on the password submitted, if the validation fails that would mean that the password is not valid so there is no point in making an API to appwrite for password check. Thus this would save us time and improve the UX.

It serves well as a response time booster. But apart from that I believe we do not aim to go down the line of realtime validation response to user while login. So there is no need for UI in it.

Please do make the suggested changes and resolve the conflicts for us to merge ASAP

@Aarush-Acharya
Copy link
Contributor

Hey @Mehul-Kumar-27 If we do not get response as a token of acknowledgement from your side in the next 3 days we would have to close this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mehul-Kumar-27 Mehul-Kumar-27

Labels
attended This PR was attended by a Reviewer awaitIntra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator not added in login Screen
3 participants
@Mehul-Kumar-27 @vrundraval24 @Aarush-Acharya