Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Anonymous text size #242

Closed
wants to merge 1 commit into from
Closed

Fixed Anonymous text size #242

wants to merge 1 commit into from

Conversation

JuanitaCathy
Copy link
Contributor

@JuanitaCathy JuanitaCathy commented Jan 7, 2024 •
edited
Loading

Description

Initially, the "Anonymous" text did not fit into the button, so reducing the size helped fix it.

Fixes #235

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

pairchatsolved

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

chandansgowda
chandansgowda requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use fitted box to make the size dynamic ?

@JuanitaCathy
Copy link
Contributor Author

Can we use fitted box to make the size dynamic ?

The username box already uses fitted box as size can vary but the Anonymous text isn't going to change right.

@AyaNady17
Copy link
Contributor

Great job @JuanitaCathy but can't we try something more responsive?

@AyaNady17 AyaNady17 added attended This PR was attended by a Reviewer awaitIntra labels May 15, 2024
@vrundraval24 vrundraval24 self-requested a review May 23, 2024 06:03
vrundraval24
vrundraval24 requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@vrundraval24 vrundraval24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @JuanitaCathy but as Chandan suggested. Please use a Fitted Box. It will solve the issue.

image

@JuanitaCathy
Copy link
Contributor Author

Good work @JuanitaCathy but as Chandan suggested. Please use a Fitted Box. It will solve the issue.

image

@vrundraval24 hello! yea i'll use a fitted box and update it.

@Aarush-Acharya
Copy link
Contributor

Aarush-Acharya commented May 24, 2024 •
edited
Loading

Hey @JuanitaCathy please do the required changes asap ... will try to merge this PR by today itself

@Aarush-Acharya
Copy link
Contributor

Hey @JuanitaCathy the UI is gonna change entire so this would be over ridden thank you for the contribution. Wishing you best for future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandansgowda chandansgowda chandansgowda requested changes

@vrundraval24 vrundraval24 vrundraval24 requested changes

Assignees

@JuanitaCathy JuanitaCathy

Labels
attended This PR was attended by a Reviewer intra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anonymous Text Size issue
5 participants
@JuanitaCathy @AyaNady17 @Aarush-Acharya @chandansgowda @vrundraval24