-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change twitter bird logo to 'X' logo in the footer section #207
Comments
hey @ashhcoder can you assign this issue to me? |
Hey @ashhcoder I would like to work on this issue. Can you please assign this issue to me? |
@ashhcoder the twitter logo should be replaced for the main body part too |
@ceilican i have pulled a request for the following changes of the twitter logo to "X" logo for the main body and the footer part if you think the pull request is correct kindly merge it as per your convenience. |
HI i have changed the twitter logo and replaced it with new one,kindly check my Pull request #PR RAISED |
@keshav861 Is Logo changed from your approach ? |
@Vegadjay yes logo is changing from my approach |
@keshav861 From where you get this logo bcz this is use react-fontawsome library and that library does not contain X logo.. from where you get this logo |
@Vegadjay ya i got this the font awesome library doesn't support for the fontawesome V5. react-fontawesome is old library. As of now i was directly using the fontawesome official react component as in node_module i added that component so thats why i think it is working and may be it wont work on it. we have to change the react-fontawesome library to react-icons library this may solve the issue or just add add a javascript file to the html file then can use this directly these are the 2 best ways to overcome this problem i think so.... |
Change the twitter bird logo to twitter 'X' logo in the footer section.
For reference:
The text was updated successfully, but these errors were encountered: