Selection background color (Mac) doesn't fit

[ingomohr]

ℹ️ Blocked by https://bugs.eclipse.org/bugs/show_bug.cgi?id=565967

---

The "Selection background" color is set to bright yellow.
Since the text in the dark theme is near white, it's hard to read.

1.0.0.202007030329
Eclipse 4.17

[AObuchow]

Thanks for reporting @ingomohr, will fix this very soon :)

[AObuchow]

IIRC on Linux the highlight foreground color is set to black, but maybe this is coming from my workspace preferences and not Spectrum Theme... I'll fix that

[AObuchow]

Hm odd, the selection foreground color is being set here https://github.com/AObuchow/Eclipse-Spectrum-Theme/blob/master/com.aobuchow.themes.spectrum/css/preference_styles.css#L40

[ingomohr]

It's the other bugger - the background.

And that one says: "Let the sun go up, up, up!" ;)

[ingomohr]

Maybe some dark grey would fit nicely :)

[AObuchow]

@ingomohr dark grey is fine with me, IIRC it used to be that color.

However, the point I was trying to make is that the foreground color shouldn't be white (as it is in your image), it should be black as seen here:

[ingomohr]

@AObuchow Ah ok. And the foreground actually is shown as "black" on the preference page. Still, when I select code, it looks kind of broken.
Do you have another hint? Maybe there's some other preference value that's not right.

The image looks as if the selection foreground is not used - or is transparent.

[AObuchow]

@ingomohr hm strange, maybe this an upstream bug. Would you mind trying to change the foreground & background color preferences manually to see if you're able to get the foreground color working?

[ingomohr]

@AObuchow I did that, but it had no effect. Maybe it's a plugin I installed. I'll try again later with the Eclipse 2020-06 release build (or 4.17M1).
Atm I'm on a 4.17 integration build.

[ingomohr]

@AObuchow I just downloaded the release build of 2020-06 (for Java and DSL devs), started in on a new workspace, installed Spectrum from the Github updatesite and restarted Eclipse.

This is what it looks like on my Mac:

Maybe, some theming behaves differently on the Mac - I don't know.
If there is something else you have that I can try, I will :)

[AObuchow]

@ingomohr I suspect this is an upstream issue then :P How do things look on the platform dark theme when highlighting text?

[ingomohr]

W/ the dark theme Eclipse is shipping with - it's at least the same approach: The foreground color doesn't change.

[PyvesB]

Will try on my own Mac tomorrow as well. :)

[AObuchow]

@ingomohr okay good to know and thank you @PyvesB !

[PyvesB]

It seems that for macOS, the foreground color property is ignored, the syntax highlighting of the original text is used. On Windows, the foreground color property is used.

[ingomohr]

It seems that for macOS, the foreground color property is ignored, the syntax highlighting of the original text is used. On Windows, the foreground color property is used.

Thanks for checking, @PyvesB. So, it actually is an upstream bug. One point for you, @AObuchow 😉

[AObuchow]

@PyvesB @ingomohr thanks for the further investigation, it seems an upstream bug is required for this one :P

[PyvesB]

I noticed another similar issue on macOS: the selection background color is ignored in some editors. I've raised https://bugs.eclipse.org/bugs/show_bug.cgi?id=565967 to flag it up. Unless both problems are linked, we may need another separate bug, as it's the foreground that is ignored here if I've understood things correctly.

[ingomohr]

I noticed another similar issue on macOS: the selection background color is ignored in some editors. I've raised https://bugs.eclipse.org/bugs/show_bug.cgi?id=565967 to flag it up. Unless both problems are linked, we may need another separate bug, as it's the foreground that is ignored here if I've understood things correctly.

Thanks for raising that bug, @PyvesB. I wonder why I haven't noticed that before...

[fabianlupa]

I have a similar issue on windows. I overwrite the selection background color by checking system default but after every restart the settings are reset to yellow (same thing for foreground color). Shouldn't the overwrite only be applied after theme switch?

[AObuchow]

@flaiker thanks for the report, I believe this might be an upstream issue with Eclipse preferences but not entirely sure yet. You are correct that this overwrite should only be applied after theme switch and not on every restart of Eclipse. Further investigation will have to be done to find the source of this bug.

I was also able to reproduce this bug on Linux, so I don't think it's a platform-dependent bug. Furthermore, it seems that it's only the "system default" preference that gets reset (disabled) upon restarting Eclipse: if you change the selection background/foreground color manually to another color, it will persist upon restarting Eclipse.

It's worth noting that Spectrum theme explicitly disables system default colors for selection, however, I did not expect it to prevent using/modifying the system default color preference. Perhaps removing this line will fix this bug.